fix: Prevent ReactEditor.toDOMRange crash in setDomSelection #5741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somehow related to #5407 and #5571
I debugged an issue in our application where using the TextExpander extension on a Slate input would cause the editor to crash with
Cannot resolve a DOM point from Slate point
coming fromsetDomSelection
's call.I was able to prevent the crash in our codebase using an ErrorBoundary as suggested here, but wondered why it was crashing to begin with.
As far as I can tell, although the TextExpander text is not expanded, the editor recovers fine if we discard the error and the existing code supports having a null
newDomRange
so I figured I could let it be null if it can't calculate adomPoint
.This pattern is already used in
ensureDomSelection
:Please let me know if I missed something!
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)