Repository navigation
Row actions: Investigate and Ask lead; merged PR starts no crew work - #34
Merged
Merged
Conversation
A merged fix PR records pr_state and one "PR #N merged" event, and nothing else: no possibly_resolved flag, no Thread Watcher run, no wake. It still joins Re-analyze, reads "Fix merged · PR #N" with Done, and the Lead gets it only through the owner's Re-analyze. The Needs-you fallback button is gone. A row now offers one real step: Investigate (a cluster, or a bug/feature not investigated yet) posts the same /investigate body the Ledger tab sends and shows the run inline from /now; Ask lead (an investigated bug/feature with no draft and no hand-off) posts /items/reanalyze for that item, and the prompt asks the Lead to decide: fix hand-off, reply draft, or close. A question with no draft gets Open; anything else gets only its ▾. /needs rows carry investigation, investigation_at, links_count, links, status and reanalyze_in_flight. Brief v10, CHARTER, CONTRACT, README (both halves) and screenshots updated; app 0.9.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1. A merged PR starts no crew work.
github_state.refreshrecordsfix_handoff.pr_stateand logs onedispatcheventPR #N merged. It no longer setspossibly_resolved, sodispatch_watcherhas nothing to hand the Thread Watcher and nothing wakes.after_pollcounts onlynew/thread_changed/possibly_resolvedfrom the poll as movement, neverpr_states. Kept: the merged item stays inneeds_reanalysis(Re-analyze count), the row readsPR #N merged ✓, the decide reasonFix merged · PR #Nwith Done, and the PR lines in the Re-analyze prompt.REANALYZE_PR_RULEand brief v10 say a merged fix reaches the Lead only through the owner's Re-analyze.2. Real row actions; the fallback button is gone.
type Primaryis now'Open' | 'Reply' | 'Dispatch fix' | 'Investigate' | 'Ask lead' | 'Done' | ''.POST /investigatewith the cluster's member keys (or the one key) andrepo: "", the same body the Ledger tab sends. No new route. Shows Investigating…, thenInvestigator · running · since HH:MM(frominvestigation_atwhile/nowshows the Investigator working), thenInvestigated · N linkswith the links under ▾. Refusals (409 unattended_required, …) show an inline ErrorNotice with one Try againPOST /items/reanalyzewith that key. Shows Lead thinking… whilereanalyze_in_flight. The prompt carriesinvestigation links: …andask: decide: fix hand-off, reply draft, or closefor that row/needsrows gainstatus,investigation,investigation_at,links_count,links(first 8) andreanalyze_in_flight. The investigator stays read-only and the unattended gate on/investigateis unchanged.3. Docs. README both halves (new Row buttons table, merged PRs only via Re-analyze), CHARTER (row Investigate is an owner action; a PR state never triggers crew work), CONTRACT (new row fields, button rules,
pr_stateno longer flags), crew_brief v10. app.json 0.9.8 with one highlights line.Testing
python -m pytest tests -q -p no:cacheprovider: 362 passed (354 on main, +8 new, 1 replaced).pr_state+ one event, sets nopossibly_resolved, is not handed to the Watcher, and does not wake the Lead;/needsrows exposeinvestigation/links_count/links/status/reanalyze_in_flight(also on clusters);reanalyze_promptcarries thedecide:ask only for rows with no draft and no hand-off; the brief names it.npm run buildclean;ui/dist/index.mjsrebuilt.shoot.mjs: all checks pass, including the new row actions check: a cluster row shows Investigate; one click posts/investigateonce with 2 keys, the button reads Investigating… (disabled) and the row readsInvestigator · running · since HH:MM; an investigated bug row shows Ask lead andInvestigated · 2 links, its ▾ lists 2 links, one click posts/items/reanalyzeonce with 1 key; a question row shows Open; nothing on the Board says "Decide". The board check now expects 8 decide rows endingOpen,Ask lead.docs/screenshots/investigate-row.png.Note: the Ledger's Investigate posts to
/investigate(not/items/investigate), so the row reuses that route.