feat: Disable rules already checked by the TypeScript compiler (#150)

iamturns · Oct 17, 2020 · 5887ed7 · 5887ed7
1 parent 6144171
commit 5887ed7
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/lib/shared.js b/lib/shared.js
@@ -205,10 +205,23 @@ module.exports = {
     {
       files: ['*.ts', '*.tsx'],
       rules: {
-        /* Using TypeScript makes it safe enough to disable the checks below */
-
-        // Disable ESLint-based module resolution check for improved monorepo support
-        // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md
+        // The following rules are enabled in Airbnb config, but are already checked (more thoroughly) by the TypeScript compiler
+        // Some of the rules also fail in TypeScript files, for example: https://github.com/typescript-eslint/typescript-eslint/issues/662#issuecomment-507081586
+        'constructor-super': 'off',
+        'getter-return': 'off',
+        'no-const-assign': 'off',
+        'no-dupe-args': 'off',
+        'no-dupe-class-members': 'off',
+        'no-dupe-keys': 'off',
+        'no-func-assign': 'off',
+        'no-new-symbol': 'off',
+        'no-obj-calls': 'off',
+        'no-redeclare': 'off',
+        'no-this-before-super': 'off',
+        'no-undef': 'off',
+        'no-unreachable': 'off',
+        'no-unsafe-negation': 'off',
+        'valid-typeof': 'off',
         'import/no-unresolved': 'off',
       },
     },