Add exception handling for instance ids #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the tests. What does the class checking give us? Am I being stupid? ;) |
|
In an ideal world we (devs) want to have an exceptions as descriptive as possible :). One application might have hundreds of instance ids objects and throwing an exception (with class name and value) for invalid input can save developer considerable debugging time. However I am open for suggestions :) |
|
still dont get it Im afraid ;) If I want to instantiate PersonId then I pass in an integer. Im probably being stupid. Can you update the tests to show what you mean? The extra tests you did are perfect. If you want them in a separate pull request I'll get those in straight away |
iamrichardjones
added a commit
that referenced
this pull request
Dec 12, 2015
Add exception handling for instance ids
|
merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exception handling for instance ids