/subscribe/payments/onetime 기능 추가 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
코드 커버리지에서 실패하는 거 같은데, 테스트 코드를 넣으려면 실제 결제가 되는 민감한 카드 정보가 있어야만 가능할 것 같습니다. |
|
일단 비정상적인 결제를 시도해서 에러메세지가 나오는지만이라도 처리해보면 어떨까 싶습니다. |
- Import와 테스트 사이 공백줄 2줄 - pytest 쓰지도 앖으니 import 없앰
|
코드 커버리지 처리 하였습니다. 일회성 결제 지원 기능 집어넣으면서, 필수 파라미터 없으면 Request 보내기 전 파이썬 단에서 미리 에러를 뱉도록 처리하였습니다. |
|
👍 감사합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.