Skip to content

Code fix and more organized structure #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iammert merged 6 commits into from
Sep 17, 2015
Merged

Code fix and more organized structure #3

iammert merged 6 commits into from
Sep 17, 2015

Conversation

@ppamorim
Copy link
Contributor

@ppamorim ppamorim commented Sep 17, 2015

Some items was changed:

  • Unnecessary libraries removed
  • More correct build.gradle file
  • Lower API
  • ProgressLayout now extends View, RelativeLayout is unnecessary in this case
  • Resources cleanup
  • Licenses added

Can you merge?

ppamorim and others added 6 commits September 16, 2015 21:27
@ppamorim
Merge pull request #1 from iammert/master
9732f73 
Update README.md
@ppamorim
Refactory
7e751e3 
Unclip the view, now we can use with another layouts.
Code cleanup, removed unnecessary libraries and a better gradle files
and gitignore.
@ppamorim
AppCompat
b212fea 
We don`t need AppCompat here
@ppamorim
Apache license
6fde902 
Apache license added and minor code fix
@ppamorim
Strings from library removed
61bf495
@ppamorim
cleanup
5cd43b3
@ppamorim
Copy link
Contributor Author

ppamorim commented Sep 17, 2015

@iammert Would ProgressLayout extends Drawable? Now I simple extends View. But extending Drawable can show some performance tips, look like this sample:

https://github.com/rey5137/material/blob/master/lib/src/main/java/com/rey/material/drawable/CircularProgressDrawable.java

I`m working on it in my branch named "cleanup" inside my fork...

@ppamorim
Copy link
Contributor Author

ppamorim commented Sep 17, 2015

If you merge this, I can solve #2 too. :)

@ppamorim
Copy link
Contributor Author

ppamorim commented Sep 17, 2015

We would change the source code style to square java style. What do you think about it?

iammert added a commit that referenced this pull request Sep 17, 2015
@iammert
Merge pull request #3 from ppamorim/master
2f5f956 
Code fix and more organized structure
@iammert iammert merged commit 2f5f956 into iammert:master Sep 17, 2015
@iammert
Copy link
Owner

iammert commented Sep 17, 2015

Thanks for PR! That makes me happy that you are interested about lib. I would like to learn something about your new PRs . So go for it :)

iammert pushed a commit that referenced this pull request Sep 17, 2015
@ppamorim
Merge pull request #3 from iammert/master
cb05c25 
Merge fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ppamorim @iammert