Handle the invalid date the same way moment.js does, with and without the utc plugin #2574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to provide consistent behavior compared to moment js.
In momentjs the
dayjs('invalid').toISOString()
-> returnsnull
But in dayjs the
dayjs('invalid').toISOString()
-> throws an errorThe desired behavior is to also return
null
.The PR changes apply to both cases, whether you use the
utc
plugin or not