Repository navigation
Bound the supervisor's stand-off for a self-managed retry and require it to be fresh (#612) - #777
Merged
Merged
Conversation
… it to be fresh (#612) The stand-off for an adapter serving its own restart backoff was keyed on a latched result code with no freshness test and no deadline, so give-up for a dead destination was a matter of poll timing, and a child whose frames stopped mid-rung could hold the supervisor off indefinitely. The stand-off now needs this cycle's record and may last at most the tallest adapter rung plus the start grace. Progress ends it; any other code resets it; past the bound the ordinary fault rules escalate with a named reason. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
iamfatness
force-pushed
the
fix/612-standoff-freshness
branch
from
October 3, 2026 02:58
478bcba to
b327627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #612
Problem
When a destination serves its own restart backoff it publishes
lastResultCode = "ffmpeg-retry-backoff", and the supervisor stands off so the adapter's bounded ladder is not walked to give-up. That stand-off was keyed on a latched code with no freshness test and no deadline:Change
In
OutputDestinationSupervisorPolicy::observe:observed); a remembered code from a child that stopped publishing does not hold the supervisor off.kSelfManagedRetryStandoffMaxMs= the tallest rung the adapter's own ladder can serve (60 s) plus the start grace (15 s). Accepted output ends the stand-off; any other result code resets the clock. When the bound is exceeded the observation goes back to the ordinary fault rules, which arm a fault with the reason "Destination reported its own retry backoff (…) for Ns without producing; the stand-off has expired." and escalate through the ladder.Nothing else changes: the terminal-code bypass, the healthy-run budget return and give-up are untouched, and a destination alternating backoff with real output (the congested-link shape) never trips the bound, since it is per stand-off.
Verification
ADestinationServingItsOwnRestartBackoffIsWaitingNotFailingnow holds the stand-off through a full tallest rung, then pins that a stale code expires at the bound and arms exactly one fault with the expiry reason.AnUnobservedBackoffCodeDoesNotHoldTheSupervisorOff(freshness) andProgressEndsAStandoffBeforeItCanExpire(six minutes of 50 s backoff bursts with output between: no fault, no give-up).ffmpeg-retry-backofffor the whole rung) is unchanged.Also drops the BACKLOG reference to #703, which the owner closed as resolved on 2026-10-02.
🤖 Generated with Claude Code