Skip to content

Dead code in the shipping core and shell #768

Description

@iamfatness

Found (read, not run).

  • Test-only commands in the production protocol with no shipping sender: fail-output-sender, recover-output-sender, fail-recording-session, recover-recording-session, simulate-breakout-room-change, set-participant-transform (payload ignored), recommend-auto-production (no-op), plus aliases native-media-core-sync and zoom-cancel. A stray recover-output-sender drops a live stream.
  • Breakout-room detection is wired only to its simulator: breakoutRoomId_ is written only by simulateBreakoutRoomChange, so the shell's "breakout room changed" hint can never fire in a real meeting.
  • ZoomMeetingSdkAdapter.cpp (935 lines) and RealZoomCaptureSource.cpp have no product caller; the first is why the core links sdk.lib.
  • recordingStatus_ never returns to "stopped" (MediaCore.cpp:2977-3043), so encoder->start(destinations...) at :2869 is effectively unreachable from WinUI and stream-only sessions do not list stream destinations in outputs.
  • C#: about 40 generated types in Contracts/Lifecycle.cs with no outside reference; NativeMediaCoreStateMapper.CopyAudioMixSession; MediaCoreBridgeService.BuildSceneGraphCommand; InMemoryRtmpIngestSourceStore; LiveProductionSync.CreateIdleFallbackPatch/MapCaptureSnapshotParticipants; SettingsViewModel.Upgrade.
  • HLS is missing from isNetworkDestination and falls into the "unknown" isolation traits (reporting only).

Done when. Test-only commands are compiled behind a fault-injection flag; unreferenced code is deleted or moved to the test target; breakout detection is either fed by the SDK or removed.

Found by the 2026-10-02 half-wired-feature audit, by reading code on main (8b84a8f). Not yet reproduced in the running app unless stated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    backlogRanked in docs/BACKLOG.md

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions