Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add lazy.nvim install description #583

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Conversation

nolleh
Copy link
Contributor

@nolleh nolleh commented May 24, 2023

add install description for lazy.nvim

description for lazy.nvim:

README.md Outdated
{
"iamcco/markdown-preview.nvim",
cmd = { "MarkdownPreviewToggle" },
ft = { "markdown" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to add a comma here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanx, I've just added the comma you menthioned.

@gabyx
Copy link

gabyx commented Jun 16, 2023

See #587 , thats the correct one

@nolleh
Copy link
Contributor Author

nolleh commented Jun 18, 2023

@gabyx
I failed to find out reply menu for your comment.

and could you kindly tell me which point is incorrect?

it's looks like personal favor,,, ^^;
tnx for opinon.

@nolleh
Copy link
Contributor Author

nolleh commented Jun 19, 2023

@gabyx
but, after seeing your PR and seeing mkdp.vim file (the plugin command definition),
It look's like other people may want to additional comment. user can use any of these command.
(to handle below command.)

  noremap <buffer> <silent> <Plug>MarkdownPreview :MarkdownPreview<CR>
  noremap <buffer> <silent> <Plug>MarkdownPreviewStop :MarkdownPreviewStop<CR>
  nnoremap <buffer> <silent> <Plug>MarkdownPreviewToggle :MarkdownPreviewToggle<CR>

So applied your opinion. ( both of our PR WAS actually not fully handle user needs ^^;)
now fully handle, from now. 👍

@V4G4X
Copy link

V4G4X commented Jul 26, 2023

This is what I'm using:

{
        "iamcco/markdown-preview.nvim",
        cmd = { "MarkdownPreviewToggle" },
        ft = { "markdown" },
        build = function() vim.fn["mkdp#util#install"]() end,
}, -- Markdown Preview

From what I understand, other than restarting neovim, no other change is required.

But when I do that and try :MarkdownPreview it does not open preview window.

How do I fix this?
Where can I find logs?

1 similar comment
@V4G4X
Copy link

V4G4X commented Jul 26, 2023

This is what I'm using:

{
        "iamcco/markdown-preview.nvim",
        cmd = { "MarkdownPreviewToggle" },
        ft = { "markdown" },
        build = function() vim.fn["mkdp#util#install"]() end,
}, -- Markdown Preview

From what I understand, other than restarting neovim, no other change is required.

But when I do that and try :MarkdownPreview it does not open preview window.

How do I fix this?
Where can I find logs?

@nolleh
Copy link
Contributor Author

nolleh commented Aug 14, 2023

This is what I'm using:

{
        "iamcco/markdown-preview.nvim",
        cmd = { "MarkdownPreviewToggle" },
        ft = { "markdown" },
        build = function() vim.fn["mkdp#util#install"]() end,
}, -- Markdown Preview

From what I understand, other than restarting neovim, no other change is required.

But when I do that and try :MarkdownPreview it does not open preview window.

How do I fix this? Where can I find logs?

actually it is little far from PR's contents, but want it to help,
I will reply :)

  1. in my envrionment, it also working by using :MarkdownPreview (look like there is some differences yours and mine in env.)
  2. if you want to print log (with debug) in markdown-preview, follow the below.

in nvim(lua)

-- the path any where you want to write
vim.env.NVIM_MKDP_LOG_FILE = "/Users/nolleh/tmp/mkdp.log"
vim.env.NVIM_MKDP_LOG_LEVEL = "debug"

in my env, log remains like this. (after running :MarkdownPreview)

2023-08-14 18:37:34 INFO (pid:43524) [app/server] - server run:  8672
2023-08-14 18:37:34 INFO (pid:43524) [app/server] - open page [default]:  http://localhost:8672/page/1
2023-08-14 18:37:34 INFO (pid:43524) [app/server] - refresh page:  1
2023-08-14 18:37:34 INFO (pid:43524) [app/server] - client connect:  mjrIp6OReWKVOwUTAAAA 1

hope this will help you.

@iamcco iamcco merged commit 4d77db3 into iamcco:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants