Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run real webpack in tests + upgrade webpack and Moment.js #6

Merged
merged 5 commits into from
Mar 24, 2018
Merged

Run real webpack in tests + upgrade webpack and Moment.js #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf35084
Update tests to perform actual webpack builds
iamakulov Mar 23, 2018
32e434e
Add .npmignore
iamakulov Mar 23, 2018
8d98386
Improve syntax checking
iamakulov Mar 23, 2018
9eed675
Fix the unknown locale warning with Moment 2.21.0
iamakulov Mar 24, 2018
a7f39df
Fix the syntax tests
iamakulov Mar 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
test
8 changes: 7 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ function normalizeLocalesToKeep(localesToKeep) {

// Check if has unknown locales
var absentLocales = localesToKeep.filter(function(localeName) {
return moment.localeData(localeName) === null;
const localeData = moment.localeData(localeName);
return (
// For Moment 2.20.1−
localeData === null ||
// For Moment. 2.21.0+ – this version now returns a default locale instead of null
localeData === moment.localeData()
);
});
if (absentLocales.length > 0) {
throw new Error(
Expand Down
54 changes: 0 additions & 54 deletions index.test.js
View file
Open in desktop

This file was deleted.

Loading