Fix the unknown locale warning with Moment 2.21.0

iamakulov · Mar 24, 2018 · 9eed675 · 9eed675
1 parent 8d98386
commit 9eed675
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -50,7 +50,13 @@ function normalizeLocalesToKeep(localesToKeep) {
 
     // Check if has unknown locales
     var absentLocales = localesToKeep.filter(function(localeName) {
-        return moment.localeData(localeName) === null;
+        const localeData = moment.localeData(localeName);
+        return (
+            // For Moment 2.20.1−
+            localeData === null ||
+            // For Moment. 2.21.0+ – this version now returns a default locale instead of null
+            localeData === moment.localeData()
+        );
     });
     if (absentLocales.length > 0) {
         throw new Error(

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
     },
     "devDependencies": {
         "jest": "^22.1.1",
-        "moment": "^2.20.1",
+        "moment": "^2.21.0",
         "proxyquire": "^2.0.1",
         "temp-dir": "^1.0.0",
         "webpack": "^4.2.0"