Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow react 17 #166

Merged
merged 1 commit into from
Dec 7, 2023
Merged

allow react 17 #166

merged 1 commit into from
Dec 7, 2023

Conversation

trajano
Copy link

@trajano trajano commented Apr 3, 2022

No description provided.

@kwnstantina
Copy link

Is it possible to merge this PR?

@pgdavidApodis
Copy link

Would be great !

@nicobermudez
Copy link

nicobermudez commented May 5, 2022

Bump. Need this to be able to use Expo.

@nicobermudez
Copy link

@iamacup any updates on this one? Seems like a simple update

@vini-coelho
Copy link

Any updates on this one? Need it to upgrade to latest Salesforce SDK.

@Tjerk-Haaye-Henricus
Copy link

Hey there, Any Update ? Would be great if this would be merged

@NilsBaumgartner1994
Copy link

push

@chrisglein
Copy link

@ImAcup There are many versions of this same change, coming from the error I imagine most of us are seeing:

warning " > react-native-markdown-display@7.0.0-alpha.2" has incorrect peer dependency "react@^16.2.0".

And if you npm list react, you'll see:

+-- react-native-markdown-display@7.0.0-alpha.2
| `-- react@18.2.0 deduped invalid: "^16.2.0" from node_modules/react-native-markdown-display

Other PRs doing similar things:

But of all of them... this one is the simplest. Seems like the least controversial merge.

@iamacup iamacup merged commit e183343 into iamacup:master Dec 7, 2023
@iamacup
Copy link
Owner

iamacup commented Dec 7, 2023

I have merged, will push a release shortly.

@chrisglein would you (or anyone else in this thread) be able to help fix this package up a bit?

I have not used React or React Native since hooks came in so i am really not best placed for it anymore.

@trajano trajano deleted the patch-1 branch December 10, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants