Fix core-quantity generated artifact tests on Windows#9330
Open
hl662 wants to merge 2 commits into
Open
Conversation
hl662
changed the title
MichaelSwigerAtBentley
approved these changes
May 22, 2026
Contributor
|
Nice, looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Generated artifact tests should catch real drift without failing because a Windows checkout used CRLF line endings. The exact string comparisons were skipped to avoid Windows-only failures, but skipping them removed coverage for generated unit identifier, conversion, and persistence artifacts.
This PR hardens the core-quantity tests by normalizing line endings before comparison (Test hardening)
The PR also pins
*.generated.tsfiles to LF across the repo so future generated TypeScript artifacts avoid the same checkout-dependent behavior (Repo hardening)Tests
Re-enabled the 3 skipped generated-artifact tests.
Validated with
rushx test,rushx lint,rushx cover,rush change -v,rush clean, andrush build.Nambot 🤖 (powered by OpenAI GPT-5.5)
Human note: I manually ran the CI pipeline and it passed