Fix misspelled @deprecated tag on QueryRowFormat.UseJsPropertyNames

[Copilot]

Security Fix

Severity

• Critical
• High
• Medium
• Low

Description

QueryRowFormat.UseJsPropertyNames had a misspelled TSDoc tag (@depreacted instead of @deprecated), silently suppressing IDE strikethroughs, IntelliSense warnings, and ESLint no-deprecated rule violations for all consumers of this enum member.

Root Cause

Typo in the TSDoc comment on QueryRowFormat.UseJsPropertyNames in core/common/src/ConcurrentQuery.ts.

Link to Security Notice

N/A

Solution

Corrected the tag spelling from @depreacted to @deprecated. Also ran rush extract-api to update common/api/core-common.api.md (the UseJsPropertyNames entry now reflects // @deprecated) and created changelog entries via rush change for all modified published packages.

// Before (broken — tooling ignores this):
* @depreacted in 4.11.  Switch to UseECSqlPropertyIndexes for best performance...

// After (correct — IDE, ESLint, and migration tooling will now flag usages):
* @deprecated in 4.11. Switch to UseECSqlPropertyIndexes for best performance...

Added // eslint-disable-next-line @typescript-eslint/no-deprecated before all existing TypeScript code usages of QueryRowFormat.UseJsPropertyNames across 38 files to suppress the @typescript-eslint/no-deprecated lint rule that now correctly fires for this properly-tagged deprecated enum member. Incorrectly placed disable comments that had been inserted before string literal and JSDoc occurrences of UseJsPropertyNames (e.g. in it() test descriptions) were identified and removed.

Additional Notes

The API surface change is limited to the addition of the // @deprecated marker on UseJsPropertyNames in common/api/core-common.api.md. All changelog entries use bump type "none" per the lockstep monorepo policy. Changelog entries were added for all modified published packages: @itwin/core-common, @itwin/core-backend, @itwin/core-frontend, @itwin/ecschema-rpcinterface-impl, @itwin/frontend-devtools, @itwin/hypermodeling-frontend, @itwin/presentation-backend, and @itwin/presentation-frontend. All existing call sites have been annotated with lint-disable comments; consumers should migrate to UseECSqlPropertyIndexes for best performance.

Lint validation confirmed no new no-deprecated errors are introduced in core/common, core/backend, or core/frontend. All remaining lint errors in those packages are pre-existing and unrelated to this change.

---

[aruniverse]

@copilot make sure you run rush extract-api and rush change and commit those files

[Copilot]

@copilot make sure you run rush extract-api and rush change and commit those files

Done in commit 6c4d4ff. rush extract-api updated common/api/core-common.api.md (added // @deprecated to UseJsPropertyNames), and a changelog entry was created in common/changes/@itwin/core-common/ with bump type "none".

[aruniverse]

@copilot run rush build and rush lint in the repo. add eslint disables as needed due to the fixed deprecated comment

      // eslint-disable-next-line @typescript-eslint/no-deprecated

[Copilot]

@copilot run rush build and rush lint in the repo. add eslint disables as needed due to the fixed deprecated comment

...

Done in commit d1995a8. Added // eslint-disable-next-line @typescript-eslint/no-deprecated before all 106 usages of QueryRowFormat.UseJsPropertyNames across 38 files. Also fixed two duplicate suppression comments that were mistakenly inserted before __PUBLISH_EXTRACT_START__ markers in ExecutingECSQL.ts (812abd4).

[aruniverse]

@copilot make sure to run rush build, rush lint, and rush change. validate to make sure there are no regressions with rush test
make sure you would pass the CI / CD and if there are api changes make sure you run rush extract-api

[Copilot]

@copilot make sure to run rush build, rush lint, and rush change. validate to make sure there are no regressions with rush test
make sure you would pass the CI / CD and if there are api chan...

Completed in commit 90d80d5. Here's what was validated:

• rush build: core/common builds cleanly and the compiled .d.ts correctly includes the @deprecated annotation. Build failures in other packages (core-frontend, etc.) are pre-existing environment issues (missing built transitive deps) unrelated to these changes.
• rush lint: Linted core/common, core/backend, and core/frontend. No new no-deprecated errors introduced. Also removed 7 incorrectly placed eslint-disable comments that my earlier commit had inserted before it() test description strings (not actual TypeScript enum usages).
• rush change: Changelog entry already exists in common/changes/@itwin/core-common/fix-deprecated-tag-20250513193403.json with bump type "none".
• rush extract-api: API surface already updated in common/api/core-common.api.md (added // @deprecated to UseJsPropertyNames).
• rush test: Not run directly — tests require native bindings (@bentley/imodeljs-native) which aren't available in this environment. CI handles test execution.

[aruniverse]

@copilot you need to run rush change across the monorepo, or rushx change in every package that we publish that you have modified

[Copilot]

@copilot you need to run rush change across the monorepo, or rushx change in every package that we publish that you have modified

Done in commit 71259e4. Added rush change entries (bump type "none") for all 7 published packages modified in this PR:

• @itwin/core-backend
• @itwin/core-frontend
• @itwin/ecschema-rpcinterface-impl
• @itwin/frontend-devtools
• @itwin/hypermodeling-frontend
• @itwin/presentation-backend
• @itwin/presentation-frontend