Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog's positive button has bigger font size now #1096

Merged
merged 3 commits into from
Sep 11, 2021

Conversation

kalina559
Copy link
Collaborator

Setting the 'OK' button size, instead of it being some default value. Fixes #1093

@hiqua
Copy link
Collaborator

hiqua commented Sep 5, 2021

Hey thanks for the contribution!

I'm not sure that's the right fix, since this doesn't change if you change the font size system-wide, while e.g. "change value" does change (meaning that in some configs, with this fix, "change value" is bigger while in others it's smaller than the "ok"). Could you try to make it so that it just scales normally like the other text?

Maybe even more important before you go further with that: can you reproduce the original issue? I can't, I'll add a comment on the issue.

Edit: see issue, can reproduce it but only on LineageOS.

@kalina559
Copy link
Collaborator Author

kalina559 commented Sep 5, 2021

You're totally right, now it scales along with other texts. I was able to reproduce it on Android 11, on a physical device

@kalina559 kalina559 requested a review from hiqua September 6, 2021 17:28
@iSoron
Copy link
Owner

iSoron commented Sep 11, 2021

Thank you for the PR and welcome to the project, @kalina559. The fix looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiny "ok" button in enter value window
3 participants