Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A month should not be treated as 30 days, and vice versa #947

Closed
2 tasks done
Geeyun-JY3 opened this issue May 31, 2021 · 1 comment
Closed
2 tasks done

A month should not be treated as 30 days, and vice versa #947

Geeyun-JY3 opened this issue May 31, 2021 · 1 comment
Labels
small-enhancement Small improvements to an existing functionality
Milestone

Comments

@Geeyun-JY3
Copy link

Geeyun-JY3 commented May 31, 2021

Pre-submission checklist

  • I am submitting a bug report, not a feature request.
  • I have searched for similar issues, but did not find any matches.

Description

This is a logic bug.

It seems that Loop treat a month as 30 days, and vice versa.

  1. Treat a month as 30 days: When setting the frequency as one time per month, it would be converted into every 30 days.
  2. Treat 30 days as a month: see screenshots below.

Steps to reproduce

This is a logic bug so no need steps.

System information

  • Phone: Mi 8
  • Phone Operating System: Android 9
  • App version: 2.0.2

Screenshots

A 1 time per month habit
image
A 2 times per month habit
image
It covers March 1 and March 2. It does not make sense. It should only cover Feburary.


BTW, the bug report issue template has a typo:

- [ ] I have have searched for similar issues, but did not find any matches.

It should be:

 - [ ] I have searched for similar issues, but did not find any matches. 
iSoron added a commit that referenced this issue Jun 5, 2021
@iSoron
Copy link
Owner

iSoron commented Jun 5, 2021

Thank you for the bug report, @Geeyun-JY3. This has been fixed in the hotfix/2.0.3 branch, and the fix should be available in the next version of the app. Here are some preview screenshots:

Every month:
Screenshot_1622929875

2 times per month:
Screenshot_1622930015

@iSoron iSoron closed this as completed Jun 5, 2021
@iSoron iSoron added the small-enhancement Small improvements to an existing functionality label Jun 5, 2021
@iSoron iSoron added this to the Loop 2.0.3 milestone Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small-enhancement Small improvements to an existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants