Fix backend header set twice

[atxr]

• Return if error to avoid setting the headers twice
  Close Error HTTP Headers already set #60

[ctmbl]

Didn't test it but seems quite logic.
If you tested it right we can merge it 👍

[amtoine]

as @ctmbl said, if you tested it, i'm fine with this 😌

just a question, and i'll approve

what is the new return supposed to do? 🤔
it only prevents the bug in #60 while keeping the rest of the website intact? 😮

[atxr]

@amtoine
The function res.status or res.sendStatus can be used only once in a route. It basically sets the response headers.
Here, without this return, this function might set the headers to 404 once and then still execute the remaining code, which will set the headers again at the end.
So this return allows to quit the function when no author is provided.

[amtoine]

The function res.status or res.sendStatus can be used only once in a route. It basically sets the response headers.
Here, without this return, this function might set the headers to 404 once and then still execute the remaining code, which will set the headers again at the end.
So this return allows to quit the function when no author is provided.

ok that makes total sense, thanks for the precision 😌

then it's great imo 👍

[amtoine]

again, waiting a bit for @gbrivady 😋
@atxr, if you feel time has passed enough, just merge this 😉

[atxr]

Shouldn't we wait for #66 before merging this one?

[amtoine]

Shouldn't we wait for #66 before merging this one?

imo, this is a bug fix so, even if it was not planned in the 0.1.1, it still is a bug fix and thus could go inside this patch version ... or after

in the end, that does not look like a big deal at all 😉

[gbrivady]

Seems fine to me