[1.20.1] Add canReachRaw target for player block breaking mixin#242
Open
Jonathing wants to merge 1 commit intoiPortalTeam:1.20.1from
Open
[1.20.1] Add canReachRaw target for player block breaking mixin#242Jonathing wants to merge 1 commit intoiPortalTeam:1.20.1from
canReachRaw target for player block breaking mixin#242Jonathing wants to merge 1 commit intoiPortalTeam:1.20.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, before anything else, I want to let you know that we've added our own workaround for Mixin injectors targetting
canReachin Forge 47.4.10. However, I still think that addressing the issue on the modder's side may be useful in this scenario.As I mentioned in the related issue, this is the "easy way" of fixing the bug I mentioned previously, to simply add
canReachRawas an injection point for the injector method.Please see my issue comment (#240 (comment)) where I discuss this in more detail. Thanks!