Skip to content

Fix postPackage hook to remove non-native SITL binaries from macOS builds #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sensei-hacker wants to merge 2 commits into
base: maintenance-9.x
Choose a base branch
from
Open

Fix postPackage hook to remove non-native SITL binaries from macOS builds #2508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204c082
Fix postPackage hook to remove non-native SITL binaries from macOS bu…
sensei-hacker Dec 29, 2025
d28fa43
Fix macOS app bundle path - find .app directory dynamically
sensei-hacker Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions forge.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,38 @@ export default {
// Remove SITL binaries for other platforms/architectures to reduce package size
postPackage: async (forgeConfig, options) => {
for (const outputPath of options.outputPaths) {
const sitlPath = path.join(outputPath, 'resources', 'sitl');
if (!fs.existsSync(sitlPath)) continue;
let sitlPath;

if (options.platform === 'darwin') {
// macOS app bundle structure: <outputDir>/<AppName>.app/Contents/Resources/sitl
// Find the .app directory
const appBundles = fs.readdirSync(outputPath).filter(f => f.endsWith('.app'));
if (appBundles.length === 0) {
console.log(`postPackage: No .app bundle found in ${outputPath}`);
continue;
}
sitlPath = path.join(outputPath, appBundles[0], 'Contents', 'Resources', 'sitl');
} else {
// Windows/Linux: <outputPath>/resources/sitl
sitlPath = path.join(outputPath, 'resources', 'sitl');
}

console.log(`postPackage: Checking SITL path for ${options.platform}: ${sitlPath}`);
if (!fs.existsSync(sitlPath)) {
console.log(`postPackage: SITL path not found, skipping: ${sitlPath}`);
continue;
}

if (options.platform === 'win32') {
console.log('postPackage: Removing non-Windows SITL binaries (linux, macos)');
fs.rmSync(path.join(sitlPath, 'linux'), { recursive: true, force: true });
fs.rmSync(path.join(sitlPath, 'macos'), { recursive: true, force: true });
} else if (options.platform === 'darwin') {
console.log('postPackage: Removing non-macOS SITL binaries (linux, windows)');
fs.rmSync(path.join(sitlPath, 'linux'), { recursive: true, force: true });
fs.rmSync(path.join(sitlPath, 'windows'), { recursive: true, force: true });
} else if (options.platform === 'linux') {
console.log('postPackage: Removing non-Linux SITL binaries (macos, windows)');
fs.rmSync(path.join(sitlPath, 'macos'), { recursive: true, force: true });
fs.rmSync(path.join(sitlPath, 'windows'), { recursive: true, force: true });
// Remove wrong architecture
Expand Down