Fix MSP decoder state corruption and send_message parameter error #2502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 5th parameter of MSP.send_message() is protocolVersion (a number), not an error callback. Passing a function caused 'Invalid MSP protocol version' exception which propagated to the isolated context, breaking serial communication until reconnect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for issues that cause the MSP decoder to enter a bad state, requiring disconnect/reconnect to recover.
Changes
1. Reset decoder state on exception (msp.js)
_dispatch_message()to ensure decoder state (message_length_received,state) is always resetprocessData()threw an exception, the decoder remained in a non-IDLE state2. Fix incorrect send_message parameter (MSPHelper.js)
MSP.send_message()call inloadLogicConditions()protocolVersion(a number), not an error callbackTesting