Fix SITL binary path resolution for dev and packaged modes

[sensei-hacker]

User description

Summary

Fixes SITL feature which was broken because the code looked for binaries in the wrong location.

Problem

The SITL path used __dirname which points to the Vite build output (.vite/build/), but SITL binaries are located in resources/public/sitl/. This meant SITL couldn't find its executables in either dev mode or packaged builds.

Changes

• Add getSitlBasePath() function that returns the correct path based on whether the app is packaged (process.resourcesPath) or in dev mode (app.getAppPath()/resources/public/sitl)
• Add extraResource in forge.config.js to include SITL binaries in packaged builds
• Add afterCopy hook to remove binaries for other platforms/architectures, reducing package size

Testing

• Verified path resolution logic for both packaged and dev scenarios
• The afterCopy hook correctly handles all platform/arch combinations including Linux arm64

Related

Alternative implementation to #2492

---

PR Type

Bug fix

---

Description

• Fix SITL binary path resolution for dev and packaged modes

• Add getSitlBasePath() function for correct path detection

• Include SITL binaries in packaged builds via extraResource

• Remove platform-specific binaries in afterCopy hook to reduce package size

---

Diagram Walkthrough

flowchart LR
  A["SITL Binary Location"] --> B{"App Packaged?"}
  B -->|Yes| C["process.resourcesPath/sitl"]
  B -->|No| D["app.getAppPath/resources/public/sitl"]
  C --> E["getSitlBasePath Function"]
  D --> E
  E --> F["chmod & startChildProcess"]
  G["forge.config.js"] --> H["extraResource adds SITL to package"]
  H --> I["afterCopy removes unused platform binaries"]

Loading

File Walkthrough

	Relevant files
Configuration changes	forge.config.js Configure SITL binary inclusion and platform filtering      forge.config.js Add extraResource configuration to include resources/public/sitl in packaged builds Add afterCopy hook that removes SITL binaries for non-target platforms and architectures Handle Linux arm64 architecture by moving binary to correct location and removing x64 variant +33/-0
Bug fix	main.js Implement dynamic SITL path resolution logic                          js/main/main.js Add getSitlBasePath() function that returns correct path based on packaged vs dev mode Replace hardcoded __dirname/sitl paths with getSitlBasePath() calls in chmod and startChildProcess handlers Function uses process.resourcesPath for packaged builds and app.getAppPath()/resources/public/sitl for dev mode +15/-2

---

[qodo-code-review]

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

[qodo-code-review]

Suggestion: Refactor the chmod IPC handler to use the promise-based fs.promises.chmod instead of wrapping the callback version in a new Promise. [general, importance: 6]

New proposed code:

-ipcMain.handle('chmod', (_event, pathName, mode) => {
-  return new Promise(resolve => {
-    chmod(path.join(getSitlBasePath(), pathName), mode, error => {
-      if (error) {
-        resolve(error.message)
-      } else {
-        resolve(false)
-      }
-    });
-  });
+ipcMain.handle('chmod', async (_event, pathName, mode) => {
+  try {
+    await chmod(path.join(getSitlBasePath(), pathName), mode);
+    return false; // Indicates success
+  } catch (error) {
+    return error.message;
+  }
 });

[qodo-code-review]

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan

ⓘ Paying users. Check that your Qodo account is linked with this Git user account