Allow a power index range of 0-4 for MSP VTX devices #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This may have a conflict with #2202. Min power needs to be 0 to allow 0mW. Current VTX support already checks for 0 and will reject it if not supported. |
sensei-hacker
added a commit
to sensei-hacker/inav-configurator
that referenced
this pull request
Dec 19, 2025
Resolves merge conflict in PR iNavFlight#2202 by adding support for dynamic power_min from firmware while maintaining backward compatibility. Changes: - Added FC.VTX_CONFIG.power_min field (default 1) - Updated MSPHelper.js to read power_min from firmware (INAV 9.1+) - Added defensive buffer checking for backward compatibility with 9.0 - Falls back to device-type logic if firmware doesn't send power_min (MSP VTX: min=0, others: min=1) - Resolved merge conflict in js/vtx.js by removing both POWER_MIN constant and getMinPower()/getMaxPower() functions - Updated tabs/configuration.js to use FC.VTX_CONFIG.power_min instead of VTX.POWER_MIN This implementation: - Works with current firmware 9.0 (graceful fallback) - Ready for future firmware 9.1 with power_min support - Eliminates hardcoded device-type logic in configurator - Maintains single source of truth in firmware Related: iNavFlight#2202 Related: iNavFlight#2206 Related: iNavFlight/inav#10395 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compliment the iNav VTX updates, this change will allow the correct number of power levels to be selected in the configurator.