Add configuration to filter out sql queries #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdaugs
force-pushed
the
skip-all-solid-cable-queries-by-default
branch
from
596539f to
3d0b023
Compare
|
iMacTia
approved these changes
Nov 11, 2024
Owner
iMacTia
left a comment
iMacTia
left a comment
There was a problem hiding this comment.
LGTM! Thank you for adding the README section as well (complete with a ref to the memory leak bug 🙇)
kakubin
reviewed
Nov 18, 2024
| Lograge::Sql.extract_event = config.extract_event || default_extract_event | ||
| Lograge::Sql.min_duration_ms = config.min_duration_ms || 0 | ||
| Lograge::Sql.query_filter = config.query_filter | ||
| Lograge::Sql.query_name_denylist = config.query_name_denylist || [/\ASCHEMA\z/, /\ASolidCable::/] |
There was a problem hiding this comment.
@fdaugs @iMacTia
Perhaps this could be better for performance and avoiding runtime error.
Suggested change
| Lograge::Sql.query_name_denylist = config.query_name_denylist || [/\ASCHEMA\z/, /\ASolidCable::/] | |
| Lograge::Sql.query_name_denylist = Regexp.union(config.query_name_denylist || [/\ASCHEMA\z/, /\ASolidCable::/]) |
related: rails/rails#46452
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to filter SQL queries by name using a denylist configuration.
SQL Query Name Denylist
query_name_denylistconfiguration option to filter out SQL queries by name using regular expressions.valid?method inlib/lograge/active_record_log_subscriber.rbto use the denylist for filtering queries.query_name_denylistattribute to theLograge::Sqlconfiguration and set default values for it.query_name_denylistin the test setup to ensure it has default values.Default value
I addition to SCHEMA-queries, queries with names starting with SolidCable:: are now also skipped. This is to prevent a issue #59 that causes a memory leak.
Additional Information
I testing this implementation of this gem locally in my application and it successfully skips all queries of solid cable.