Add option query_filter to allow filter out sensitive data
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
iMacTia
approved these changes
Oct 18, 2023
Owner
iMacTia
left a comment
iMacTia
left a comment
There was a problem hiding this comment.
@nhatle-684 this looks great! Thank you for taking a stab at it.
There are a few minor rubocop/style issues, but I can take care of them before releasing 👍, the implementation itself looks good 🙌
This was referenced Oct 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @iMacTia,
I'm implement suggestion from #50: Add a configurable lambda to apply the filtering to
event.payload[:sql].Although currently, this already possible by config
extract_eventorformatterbut this seem cleaner if we just want to filter sensitive data out.