Skip to content

Add option min_duration_ms to filter SQL Events #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iMacTia merged 2 commits into from
Feb 24, 2023
Merged

Add option min_duration_ms to filter SQL Events #40

iMacTia merged 2 commits into from
Feb 24, 2023

Conversation

@rs-phunt
Copy link
Contributor

@rs-phunt rs-phunt commented Feb 23, 2023 •
edited
Loading

Add option min_duration_ms to filter SQL Events

This option very helpful to filter Slow SQL Queries

lograge-sql is also incredible. Thank you 🥰

iMacTia
iMacTia requested changes Feb 23, 2023
View reviewed changes
Copy link
Owner

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rs-phunt, this is a really great addition!
I've requested to change the name of the config to make it more self-explanatory, and suggested a small change on a comment, but otherwise this looks good 👍 !

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rs-phunt rs-phunt changed the title Add option limit_duration to filter SQL Events Add option min_duration_ms to filter SQL Events Feb 24, 2023
iMacTia
iMacTia approved these changes Feb 24, 2023
View reviewed changes
Copy link
Owner

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna merge this as is and then do CI fixes in main, thank you @rs-phunt 🙏

@iMacTia iMacTia merged commit 667bdb2 into iMacTia:master Feb 24, 2023
iMacTia added a commit that referenced this pull request Feb 24, 2023
@iMacTia
Add test coverage for #40
e79fbb6
@iMacTia iMacTia mentioned this pull request Feb 24, 2023
Merged
iMacTia added a commit that referenced this pull request Feb 24, 2023
@iMacTia
Add test coverage for #40
fe93a77
@rs-phunt
Copy link
Contributor Author

rs-phunt commented Feb 25, 2023

@iMacTia

Great 🎉
Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rs-phunt @iMacTia