-
Notifications
You must be signed in to change notification settings - Fork 2
feat: support trailing commas in config and improve error handling #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @iHildy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and user-friendliness of configuration handling by introducing support for trailing commas in JSONC files, making configuration more flexible. It also bolsters error handling during config loading to provide clearer feedback to users and improves the reliability of toast notifications. Additionally, it includes minor updates to development workflow configurations. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for trailing commas in JSONC configuration files and improves error handling. The implementation for stripping trailing commas in src/sync/config.ts is functional but could be made more efficient and maintainable by combining it with the existing comment-stripping logic to avoid parsing the string twice. Additionally, a new configuration file opencode.json has been added with a hardcoded local file path, which is a critical issue that needs to be addressed to ensure portability and prevent information leakage. The error handling improvements in src/sync/service.ts and src/sync/utils.ts are well-implemented and enhance the robustness of the plugin.
|
I've addressed the reviewer feedback:
Verified with |
Summary
Adds support for trailing commas in JSONC-config via parseJsonc, improves error handling on config load, and extends tests and workflow config.
Changes
src/sync/config.tsand apply it inparseJsoncsrc/sync/config.test.tsstartupSyncto catch load errors and notify via toastshowToastresilient to failures (headless mode)opencode.jsonand smoke workflow enhancements to wire opencode-synced pluginpackage.jsonfiles field formatting and lint-staged configparseJsoncTesting
bun testto verifyparseJsoncparsing and existing testsopencode-synced.jsoncand runs smoke tests