Merged
Conversation
Member
|
Thanks for the PR! The core logic for email-based deduplication is solid, and the code quality is great 👍 After testing and reviewing the code, I think there are a few areas we can refine further. I'll make these changes after merging this PR: 1. Manual Account Switching Should Not Auto-RedirectWhen a user manually selects a specific account to switch to, we should respect their choice rather than auto-redirecting to the latest index of the same email. Reasons:
2. New Auth Index StrategyI'm also planning to change the new auth index allocation to always be greater than the current maximum index, instead of searching for gaps starting from 0. This simplifies the assumption that higher index = newer auth. Thanks again for the contribution! 🙏 |
Contributor
Author
|
I’d be happy to see that. 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.
index-ordering assumption.
and adds a “Deduplicate Auth” button with i18n strings (EN/ZH).
#0 auth json: it should redirect to#1 auth json (latest).