Support Proto Editions

[ansemjo]

Hey! I was trying to use your generator with an existing ConnectRPC project but protoc-gen-connecpy fails because it doesn't support the editions syntax yet:

proto/v1/messages.proto: is an editions file, but code generator protoc-gen-connecpy hasn't been updated to support editions yet. Please ask the owner of this code generator to add support or switch back to proto2/proto3.

I am currently using edition = "2023"; at the top of my .proto file.

Is that possibly a simple fix to add it to the resp.SupportedFeatures value?

connecpy/protoc-gen-connecpy/generator/generator.go

Line 16 in 6941d57

resp.SupportedFeatures = proto.Uint64(uint64(plugin.CodeGeneratorResponse_FEATURE_PROTO3_OPTIONAL))

[i2y]

@ansemjo Thank you for reporting this issue!
I've now created a tiny PR based on your suggestion.
It works, but it probably doesn't support all of the new syntaxes, although I'm not entirely sure.

[ansemjo]

Thanks a lot! I installed the binary from your PR's branch and it did compile a messages_connecpy.py successfully. I am not entirely sure what, if any, syntax is really new about editions so far. Back when I decided which one to use it just seemed to have more sensible choices regarding the "field presence" rules but I left all the syntax basically unchanged from proto3.

Here's the command to install a binary from a branch directly, in case anyone else stumbles upon this:

GOPROXY=direct go install github.com/i2y/connecpy/protoc-gen-connecpy@feat/initial-support-for-edition-2023

---

I still can't quite use connecpy yet because the generator gets the namespacing of nested messages wrong, it appears. That's unrelated to this issue, though, I think.

Still, you can see my service definition here:
https://github.com/wasimoff/wasimoff/blob/69e3a4fd658751ea4720f118d3fe5b8879ae46cc/proto/v1/messages.proto#L198-L211
In the rpc functions I use request and response messages in a nested namespace, like Task.Wasip1.Request. However, the generator writes a Python file, which attempts to use _pb2.Request instead:

class TasksSync(Protocol):
    def RunWasip1(self, req: _pb2.Request, ctx: ServiceContext) -> _pb2.Response: ...
    def RunWasip1Job(self, req: _pb2.JobRequest, ctx: ServiceContext) -> _pb2.JobResponse: ...
    def RunPyodide(self, req: _pb2.Request, ctx: ServiceContext) -> _pb2.Response: ...
    def Upload(self, req: _pb2.Request, ctx: ServiceContext) -> _pb2.Response: ...