Repository navigation
Fix mirrored 3D plot meshes - #57
Open
shanedertrain wants to merge 1 commit into
Open
shanedertrain wants to merge 1 commit into
shanedertrain wants to merge 1 commit into
Conversation
Snaiderbg
pushed a commit
to Snaiderbg/Backplane
that referenced
this pull request
Oct 9, 2026
Dictation goes in at the caret and reads on; dev installs ship the fast voice helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mirrored 3D plot meshes
The web and phone 3D viewers show reflected geometry compared with KiCad because the shared mesh encoder swaps glTF Y and Z without preserving handedness. Rotate Y-up coordinates to Z-up as (x, -z, y), preserving asymmetric landmark positions and triangle winding. Apply the same conversion to mesh bounds.
Add regression coverage that decodes the encoded mesh and checks asymmetric positions, upward-facing winding, rotated bounds, and signed underside coordinates. Update the existing serialized mesh expectation.
Validation:
This PR contains only the mesh conversion and its regression tests.
Fixes #45