Skip to content

Comments

fix #1899#1900

Merged
adrai merged 1 commit intoi18next:masterfrom
cellog:issue-1899-fix
Jan 10, 2026
Merged

fix #1899#1900
adrai merged 1 commit intoi18next:masterfrom
cellog:issue-1899-fix

Conversation

@cellog
Copy link
Contributor

@cellog cellog commented Jan 10, 2026

This change fixes the issue raised by @robintown. The types for Trans did not have a default value for Key, which is what was causing the breakage.

Basically, IcuTrans requires a key, so there is always a value to infer from. For Trans, where the key is optional, the value was inferred as the full ParseKeys<...> type. The bug was introducing a default of = string. This is unnecessary and was the root cause of the problem.

@robintown can you please try this fix on your local codebase and confirm it works?

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

coveralls commented Jan 10, 2026

Coverage Status

coverage: 97.682%. remained the same
when pulling 346f41f on cellog:issue-1899-fix
into 3b4e102 on i18next:master.

@adrai
Copy link
Member

adrai commented Jan 10, 2026

@cellog fyi: the typescript tests fails

@cellog cellog force-pushed the issue-1899-fix branch 2 times, most recently from f9598c9 to b250225 Compare January 10, 2026 22:36
@cellog
Copy link
Contributor Author

cellog commented Jan 10, 2026

I gotchu

@adrai adrai merged commit 988cd3f into i18next:master Jan 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants