Merged
Conversation
Member
|
@cellog fyi: the typescript tests fails |
f9598c9 to
b250225
Compare
b250225 to
346f41f
Compare
Contributor
Author
|
I gotchu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the issue raised by @robintown. The types for
Transdid not have a default value forKey, which is what was causing the breakage.Basically, IcuTrans requires a key, so there is always a value to infer from. For Trans, where the key is optional, the value was inferred as the full
ParseKeys<...>type. The bug was introducing a default of= string. This is unnecessary and was the root cause of the problem.@robintown can you please try this fix on your local codebase and confirm it works?
Checklist
npm run test