Skip to content

Conversation

@cellog
Copy link
Contributor

@cellog cellog commented Oct 21, 2025

Discovered in the wild: we need to use 'quoted-strings' for props in contents that are not valid identifiers in javascript.

This fixes that (reference #1869)

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 97.598% (+0.005%) from 97.593%
when pulling 998f4f7 on cellog:issue-1869-quote-props-bug
into 10c2c57 on i18next:master.

@adrai adrai merged commit a2afed6 into i18next:master Oct 21, 2025
9 checks passed
@adrai
Copy link
Member

adrai commented Oct 21, 2025

v16.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants