feat: use IcuTrans as the compiled output of ICU trans macro

[cellog]

Issue #1869

This is the 2nd of 3 PRs (third will be docs)

This transforms the component under the hood for Trans, Select, Plural, and SelectOrdinal to use the IcuTrans component just committed a few hours ago.

I managed to bump test coverage a wee bit higher in this one.

For the next PR: which docs should I update, and should I add new ones?

Checklist

• only relevant code is changed (make a diff before you submit the PR)
• run tests npm run test
• tests are included
• commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

• only relevant documentation part is changed (make a diff before you submit the PR)
• motivation/reason is provided
• commit message and code follows the Developer's Certification of Origin

[coveralls]

coverage: 97.593% (+0.4%) from 97.208%
when pulling 4888218 on cellog:issue-1869-icu.macro
into 62d6c2c on i18next:master.

[adrai]

is this still ok? https://github.com/i18next/react-i18next/blob/master/icu.macro.d.ts

can you fix also this double dot here? https://github.com/i18next/react-i18next/blob/master/package.json#L52

regarding docs: https://react.i18next.com/misc/using-with-icu-format#using-babel-macros-trans-plural-select (https://github.com/i18next/react-i18next-gitbook/blob/master/misc/using-with-icu-format.md)
and it would be nice if you could also update this example: https://github.com/i18next/react-i18next/blob/master/example/react-icu/src/ComponentUsingMacro.js https://github.com/i18next/react-i18next/blob/master/example/react-icu/src/ComponentUsingMacroInterpolated.js

[cellog]

is this still ok? https://github.com/i18next/react-i18next/blob/master/icu.macro.d.ts

Yes, this is a drop-in replacement, none of the public API has changed

can you fix also this double dot here? https://github.com/i18next/react-i18next/blob/master/package.json#L52

lol good catch :)

regarding docs: https://react.i18next.com/misc/using-with-icu-format#using-babel-macros-trans-plural-select (https://github.com/i18next/react-i18next-gitbook/blob/master/misc/using-with-icu-format.md) and it would be nice if you could also update this example: https://github.com/i18next/react-i18next/blob/master/example/react-icu/src/ComponentUsingMacro.js https://github.com/i18next/react-i18next/blob/master/example/react-icu/src/ComponentUsingMacroInterpolated.js

Thanks! I'll work on those next!

[adrai]

Will create a new release as soon as you've prepared the docs etc.

[cellog]

Will create a new release as soon as you've prepared the docs etc.

Working on them now. Thank you for being so flexible and for accepting this work!

[cellog]

it would be nice if you could also update this example: https://github.com/i18next/react-i18next/blob/master/example/react-icu/src/ComponentUsingMacro.js https://github.com/i18next/react-i18next/blob/master/example/react-icu/src/ComponentUsingMacroInterpolated.js

Those examples don't need updating because they work without modification (100% backwards-compatible API, only the under-the-hood implementation has changed)

[cellog]

I just realized that the defaults prop could be used to pass in a translation directly. I will have to add that support in a follow-up PR, will do that today.

[cellog]

oh! No I am wrong, that aspect of the icu macro is fully tested, and working. I just didn't know about it. Please disregard 😂

[cellog]

i18next/react-i18next-gitbook#153