Custom slot name braces #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkuegler, PTAL |
adrai
reviewed
Jun 27, 2023
adrai
reviewed
Jun 27, 2023
| <i18n> | ||
| { | ||
| "en": { | ||
| "message": "Open the <slot>faq-link</slot> page." |
There was a problem hiding this comment.
cool... similar to react-i18next named tags => https://react.i18next.com/latest/trans-component
kkuegler
reviewed
Jun 27, 2023
index.ts
Outdated
| @@ -5,6 +5,10 @@ declare module 'vue' { | |||
| interface ComponentCustomProperties { | |||
| $t: TFunction; | |||
| $i18next: i18n; | |||
| // Optional custom pattern for matching slot start of the `TranslationComponent. Internal. | |||
There was a problem hiding this comment.
To me it seems better to not have these internal properties be part of the public ComponentCustomProperties type, as I can't think of a use-case for them in user components, We can just use the internal propertie(s) without declaring them.
…om public API. Address performance issue. Simplify `slotNamePattern()`
|
@kkuegler, PTAL again. |
|
Looks good. Thanks again for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I introduce the possibility to provide custom start and end braces (or other string values) used to recognize the end and start of a slot of the
TranslationComponent.This may be useful when default braces (
{and}) are wrongly treated by the Locize service or don't satisfy other needs. In our case, the Locize treated single braces as "wrong" double braces, so we couldn't sync our localization terms with the Locize service without additional refactoring. This service is needed for our translators to edit localization terms and see how it looks in real time. We have to do double refactoring each time before sync. To avoid it, I propose a little change in this repo.Checklist
npm run testChecklist (for documentation change)