Fix a use-after-free bug in xls/visualization/sched_printer_main.cc.

PiperOrigin-RevId: 681567169
hzeller · Oct 2, 2024 · e827137 · e827137
1 parent c82c620
commit e827137
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/xls/visualization/sched_printer_main.cc b/xls/visualization/sched_printer_main.cc
@@ -347,8 +347,10 @@ absl::Status RealMain(std::string_view ir_path) {
   XLS_RETURN_IF_ERROR(VerifyPackage(p.get()));
 
   std::string top_str = absl::GetFlag(FLAGS_top);
-  std::optional<std::string_view> maybe_top_str =
-      top_str.empty() ? std::nullopt : std::make_optional(top_str);
+  std::optional<std::string_view> maybe_top_str;
+  if (!top_str.empty()) {
+    maybe_top_str = top_str;
+  }
   XLS_ASSIGN_OR_RETURN(FunctionBase * main, FindTop(p.get(), maybe_top_str));
 
   XLS_ASSIGN_OR_RETURN(