animation: allow/intend for animated vars to be unique pointers #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We could also change some of the member naming in this PR or in a PR intended for the same breaking release, since that would also break ABI + API. Like |
This was referenced Nov 27, 2025
Member
|
this already breaks API which I dont like. Can't we have create2 and so on? |
Contributor
Author
|
Yep, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think animated variables should be unique pointers.
When they were added to HU, WP's couldn't point to UP's so we would have had to use raw pointers.
But now that you can construct a WP from a UP, I think it does make sense.
Breaks ABI so feel free to defer merging in case you want this.