Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cyclenext, visible parameter #9045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Truenya
Copy link
Contributor

@Truenya Truenya commented Jan 12, 2025

Describe your PR, what does it fix/add?

#6678
cyclenext, visible shoud works as cyclenext, but also cycling other monitor windows

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

nothing

Is it ready for merging, or does it need work?

ready for merging

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not against this, but why not just add next visible and prev visible to cyclenext?

as in

bind = SUPER,amogus,cyclenext,visible
bind = SUPER,amogus,cyclenext,prev visible

@Truenya
Copy link
Contributor Author

Truenya commented Jan 13, 2025

not against this, but why not just add next visible and prev visible to cyclenext?

as in

bind = SUPER,amogus,cyclenext,visible
bind = SUPER,amogus,cyclenext,prev visible

sounds great, I'll make some edits

@Truenya Truenya marked this pull request as draft January 13, 2025 15:48
@Truenya Truenya marked this pull request as ready for review January 13, 2025 16:03
@Truenya Truenya changed the title feat: cyclenextvisible dispatcher feat: cyclenext, visible parameter Jan 13, 2025
@Truenya
Copy link
Contributor Author

Truenya commented Jan 13, 2025

@vaxerski that way - done

I'm rereading it and thinking that maybe it would be better to make this behavior the default, and make the workspace cycle optional, and change the function names?

@Truenya
Copy link
Contributor Author

Truenya commented Jan 13, 2025

hyprwm/hyprland-wiki#945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants