exec(-onec) with rules and execr(-once) #8953
Open
+56
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littleblack111
force-pushed
the
exec-once
branch
from
94ad4d2 to
563de24
Compare
vaxerski
reviewed
Jan 5, 2025
|
conflict |
littleblack111
force-pushed
the
exec-once
branch
from
3e23e14 to
571cb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
currently both exec-once and exec does not support window rule like their dispatchers, i've added that feature and also added execr and execr-once
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
for the change in firstExecRequests, not sure if i shall also do that to finalExecRequests, i think it's better to keep it as it is, since exec-shutdown is executed when shutting down thus it's not necessary for window rule?
Is it ready for merging, or does it need work?
ready