-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: move parts of the animation system to hyprutils #8868
Conversation
4f571c1
to
263bfec
Compare
980873a
to
937a36c
Compare
I've pushed hyprutils 0.3.1, cmakelists can be updated |
with HU 0.3.2 https://github.com/hyprwm/hyprutils/releases/tag/v0.3.2 I assume this should also move to the config tree before mergin? |
Yes sir, i think that would be best |
137b7aa
to
18bbbe9
Compare
I am going to rebase and cleanup the commit history of this PR so that all updates regarding the usage of animated variables (so adding Hopefully that will make it a bit easier to review. |
thanks :) tag me when ready |
d2f9ba3
to
6519c70
Compare
6519c70
to
ed23035
Compare
@vaxerski ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Requires hyprwm/hyprutils#27
Describe your PR, what does it fix/add?
Moves core components of the animation system to hyprutils. (In order to use it in hyprlock as well)
Introduces smart pointers for animated variables and animation properties.
Interface changes:
g_pAnimationManager->createAnimation
. That function takes a value to always have AnimatedVaraibles explicitly initialized to a value.*m_vRealSize = Vector2D(42,42)
and in a change fromav.setValue
toav->setValue
av->setConfig
.CAnimatedVaraible
now has member functionsenabled
,getBezierName
andgetStyle
to get their config properties more easily.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Needs testing.
The damage handling was refactored a bit. Previously it damaged before and after a variable update inCAnimationManager::tick
. I don't think that is needed and from what i tested it works the same as before.Possibly needs to be reverted to how it worked before, but the damage handling needs to be moved into functions, because we need to upcast first to get the context of animated variables.
Is it ready for merging, or does it need work?
Need some testing and review.