-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Better submaps #11760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Better submaps #11760
Conversation
If hyprlang would allow for { } i would be so happy.
I don't see the point. Why not just use the current submaps to move to and from? It doesn't address the issue to me? |
? Wasn't the issue that there should be a way to go back to default submap when a keybind is triggered? And the reason i moved it to a struct was so that hopefully in the future there is a better way to parse { }, and then it would be easy to make a neat push pop stack structure for submaps. |
oh yeah sorry got confused there with your description |
Lets you define what submap you want to go to instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm, needs a wiki mr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests needed, code OK
Describe your PR, what does it fix/add?
Addresses: #10659
But not quite a good solution yet.
What i really wanted was a syntax like this:
Then a stack of submaps to keep track of where we are.
Hyprlang doesn't really allow for this though. So this is what i ended up with.
Using the syntax:
With it being just strings floating around it's really hard to cascade parents.
So for now if a submap is oneshot, it just resets submap to default.
I made a version using containers instead which made it trivial to go to nearest none oneshot, but felt heavy and unnecessary without a different way to nest submaps. Like, how many layers are people really going to put in?
Is it ready for merging, or does it need work?
Probably not. Some suggestions on how to make this look better would be nice.