Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-Bound monitor failure mode is unclear #113

Closed
krlhBlupine opened this issue Jun 14, 2024 · 3 comments
Closed

Force-Bound monitor failure mode is unclear #113

krlhBlupine opened this issue Jun 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@krlhBlupine
Copy link

Pyprland version
2.3.7

Describe the bug
Failure mode when scratchpad is force-bound to a non-present monitor is unclear. Received an error for 'no monitor is focused' first, then received a 'NoneType is not scriptable' error. I feel like a clearer error message would do some good, and a fallback to the focused monitor might be even better.

To Reproduce
Steps to reproduce the behavior:

[pyprland]
plugins = ["scratchpads", "expose"]

[scratchpads.term]
animation = "fromBottom"
command = "kitty --class kitty-dropterm --single-instance"
position = "13% 36%"
# force_monitor = "DP-3"
restore_focus = true


[expose]
include_special = true

Uncomment line, (presuming you don't have a 'DP-3'), reload, summon the scratchpad.

@krlhBlupine krlhBlupine added the bug Something isn't working label Jun 14, 2024
@krlhBlupine krlhBlupine changed the title [BUG] Enter a short bug description here Force-Bound monitor failure mode is unclear Jun 14, 2024
@fdev31
Copy link
Collaborator

fdev31 commented Jun 14, 2024

Fair enough :)

  • The message is clearly to be improved
  • Should fallback to "not force anything"

Thank you for the report!

I'm a bit more slow for a couple of weeks since I'm traveling but I'll look at it when possible.

fdev31 added a commit that referenced this issue Jun 14, 2024
@fdev31
Copy link
Collaborator

fdev31 commented Jun 14, 2024

Feel free to test the git version & provide some feedback!

@krlhBlupine
Copy link
Author

Hey! Apologies for the delay, I'm having some trouble building on NixOS specifically. I can get back to you when I actually have my virtual system set up again. Just from what I can see in the commit though, everything looks pretty good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants