Wait for healthchecks in make services#141
Merged
robertknight merged 1 commit intomainfrom Jul 10, 2023
Merged
Conversation
This enables starting apps with `make services dev` without potentially running into errors from the app due to services not being ready when the web server tries to connect. Services must define a healthcheck [1] in `docker-compose.yml` for this to work. The `--wait` flag is missing from the Docker Compose docs, but see docker/compose#8777. [1] https://docs.docker.com/compose/compose-file/05-services/#healthcheck
seanh
approved these changes
Jul 10, 2023
Contributor
seanh
left a comment
seanh
left a comment
There was a problem hiding this comment.
This will cause PRs to be sent to all cookiecutter-using projects that have services, so we may need to add missing healthchecks to some of those services when those PRs come.
robertknight
added a commit
to hypothesis/lms
that referenced
this pull request
Jul 10, 2023
This is the result of running `make template`, to apply the changes from hypothesis/cookiecutters#141.
robertknight
added a commit
to hypothesis/lms
that referenced
this pull request
Jul 10, 2023
This is the result of running `make template`, to apply the changes from hypothesis/cookiecutters#141.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables starting apps with
make services devwithout potentially running into errors from the app due to services not being ready when the web server tries to connect.Services must define a healthcheck [1] in
docker-compose.ymlfor this to work.The
--waitflag is missing from the Docker Compose docs, but see docker/compose#8777.[1] https://docs.docker.com/compose/compose-file/05-services/#healthcheck