Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now init message has double slash #78

Merged
merged 2 commits into from
Nov 2, 2019

Conversation

horacimacias
Copy link

No description provided.

cmd/helms3/proxy.go Outdated Show resolved Hide resolved
if strings.HasSuffix(act.uri, "index.yaml") && err == awss3.ErrObjectNotFound {
return fmt.Errorf("The index file does not exist by the path %s. If you haven't initialized the repository yet, try running \"helm s3 init %s\"", act.uri, path.Dir(act.uri))
if strings.HasSuffix(act.uri, indexYaml) && err == awss3.ErrObjectNotFound {
return fmt.Errorf(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST1005: error strings should not be capitalized (from stylecheck)

@hypnoglow
Copy link
Owner

Thanks!

Unfortunately, the patch did not work properly, e.g. for url s3://foo/bar/baz/index.yaml it was returning The index file does not exist by the path s3://foo/bar/baz/index.yaml. If you haven't initialized the repository yet, try running "helm s3 s3://foo/b".

I added a commit to address this, I hope you don't mind.

@hypnoglow hypnoglow merged commit 0bd6100 into hypnoglow:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants