feat: make dynamic bucket region detection optional #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for disabling dynamic bucket region detection via the
HELM_S3_DYNAMIC_REGION
environment variable.Problem
The current implementation of
DynamicBucketRegion
always performs automatic bucket region detection by making HEAD requests to Amazon S3, which causes several issues:s3.amazonaws.com
s3.amazonaws.com
) regardless of custom endpoints configured viaAWS_ENDPOINT
or AWS profilesSolution
Introduce
HELM_S3_DYNAMIC_REGION
environment variable:true
(enabled) - maintains backward compatibilityfalse
: Disables dynamic region detection, relies on standard AWS region configurationChanges
ConditionalDynamicBucketRegion()
function that respects the new environment variableUsage
To disable dynamic bucket region detection:
export HELM_S3_DYNAMIC_REGION=false
This is particularly useful for:
Testing
All existing tests pass, and new tests verify:
Backward Compatibility
✅ Fully backward compatible - existing users will see no change in behavior unless they explicitly set
HELM_S3_DYNAMIC_REGION=false
.Fixes #220