Skip to content

Commit

Permalink
Updates based on owner's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Prem Joseph committed Nov 3, 2023
1 parent 9037ea3 commit 27a2cdd
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions internal/helmutil/index.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ type Index interface {
// SortEntries sorts the entries by version in descending order.
SortEntries()

// Add Last Generated TimeStamp.
TimeStamp()
// Updated Last indexation TimeStamp.
UpdateGeneratedTime()

// MarshalBinary encodes index to a binary form.
MarshalBinary() (data []byte, err error)
Expand Down
2 changes: 1 addition & 1 deletion internal/helmutil/index_v2.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (idx *IndexV2) SortEntries() {
idx.index.SortEntries()
}

func (idx *IndexV2) TimeStamp() {
func (idx *IndexV2) UpdateGeneratedTime() {
idx.index.Generated = time.Now()
}

Expand Down
2 changes: 1 addition & 1 deletion internal/helmutil/index_v2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func TestIndexV2_Timestamp(t *testing.T) {
},
}
generatedOld := idx.index.Generated
idx.TimeStamp()
idx.UpdateGeneratedTime()
generatedNew := idx.index.Generated
assert.True(t, generatedNew.After(generatedOld), "Expected %s greater than %s", generatedNew.String(), generatedOld.String())
}
2 changes: 1 addition & 1 deletion internal/helmutil/index_v3.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (idx *IndexV3) SortEntries() {
idx.index.SortEntries()
}

func (idx *IndexV3) TimeStamp() {
func (idx *IndexV3) UpdateGeneratedTime() {
idx.index.Generated = time.Now()
}

Expand Down
2 changes: 1 addition & 1 deletion internal/helmutil/index_v3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func TestIndexV3_Timestamp(t *testing.T) {
},
}
generatedOld := idx.index.Generated
idx.TimeStamp()
idx.UpdateGeneratedTime()
generatedNew := idx.index.Generated
assert.True(t, generatedNew.After(generatedOld), "Expected %s greater than %s", generatedNew.String(), generatedOld.String())
}
2 changes: 1 addition & 1 deletion plugin.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: "s3"
version: "0.15.2"
version: "0.15.1"
usage: "Manage chart repositories on Amazon S3"
description: |-
Provides AWS S3 protocol support for charts and repos. https://github.com/hypnoglow/helm-s3
Expand Down

0 comments on commit 27a2cdd

Please sign in to comment.