Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SOCKS support. #18

Closed
wants to merge 1 commit into from
Closed

Add SOCKS support. #18

wants to merge 1 commit into from

Conversation

jabberwock
Copy link

Add support for SOCKS4 and SOCKS5 proxies via PySocks.

@hypn0s
Copy link
Owner

hypn0s commented Apr 10, 2020

Hi @jabberwock , thank you for your PR!

I'm sorry but I won't merge this PR. The reason is that I don't want external dependencies to allow the code to be run anywhere. As the users of this script can not install dependencies, it is easier to let the user uses tools such as tsocks or proxychains.

Anyway, thank you for your PR again, I hope you understand my point of view :)

@hypn0s hypn0s closed this Apr 10, 2020
@jabberwock
Copy link
Author

@hypn0s I understand. I did this for my own needs as proxychains doesn't work with Python in many environments due to the nature of glibc's dynamic linker across different versions. I am also testing from macos which doesn't have tsocks natively, or in Homebrew. Thank you for your response and clarification of your goal to keep this awesome program simple.

-jw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants