Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

Fix set focusedRange to end date does not seems to make effect - #508

Open
rhogeranacleto wants to merge 3 commits into
hypeserver:masterfrom
605data:fix/focused-range-show-date-on-calendar
Open

Fix set focusedRange to end date does not seems to make effect#508
rhogeranacleto wants to merge 3 commits into
hypeserver:masterfrom
605data:fix/focused-range-show-date-on-calendar

Conversation

@rhogeranacleto

Copy link
Copy Markdown

Types of changes

This PR fixes the bug when setting the focusedRange={[0, 1]} does not show the end date of the range.

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

This PR basically changes this line

const targetDate = targetInterval.start || targetInterval.end || shownDate || new Date();
to take into account the rangeElement param of focusedRange to set the shownDate.

Related Issue: fixes #506

@inzKornel

Copy link
Copy Markdown

Maybe it is time to merge it? I faced the same issue and got stuck @burakcan @kamyar @mkg0

@YovkaHan

YovkaHan commented Feb 7, 2022

Copy link
Copy Markdown

@burakcan @kamyar @mkg0, guyz, are u there ?

@delete-merged-branch
delete-merged-branch Bot deleted the fix/focused-range-show-date-on-calendar branch February 28, 2022 19:29
@rhogeranacleto
rhogeranacleto restored the fix/focused-range-show-date-on-calendar branch March 8, 2022 12:41
@ohiomanbo

Copy link
Copy Markdown

knock knock

@burakcan

burakcan commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator

Please check the README.md. This project is currently not maintained by the authors. If anyone is willing to maintain, we'll add links to the active forks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting focusedRange to end date does not seems to make effect

5 participants