-
Notifications
You must be signed in to change notification settings - Fork 701
Support for customizable static range labels #271
Changes from all commits
c8ce7bd
fb15e54
5e4eb44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
/node_modules/* | ||
/lib/* | ||
/dist/* | ||
**/*.snap |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ class DefinedRanges extends Component { | |
}; | ||
this.handleRangeChange = this.handleRangeChange.bind(this); | ||
} | ||
|
||
handleRangeChange(range) { | ||
const { onChange, ranges, focusedRange } = this.props; | ||
const selectedRange = ranges[focusedRange[0]]; | ||
|
@@ -22,6 +23,7 @@ class DefinedRanges extends Component { | |
[selectedRange.key || `range${focusedRange[0] + 1}`]: { ...selectedRange, ...range }, | ||
}); | ||
} | ||
|
||
getSelectedRange(ranges, staticRange) { | ||
const focusedRangeIndex = ranges.findIndex(range => { | ||
if (!range.startDate || !range.endDate || range.disabled) return false; | ||
|
@@ -30,14 +32,24 @@ class DefinedRanges extends Component { | |
const selectedRange = ranges[focusedRangeIndex]; | ||
return { selectedRange, focusedRangeIndex }; | ||
} | ||
|
||
render() { | ||
const { onPreviewChange, ranges, rangeColors, className } = this.props; | ||
const { onPreviewChange, ranges, renderStaticRangeLabel, rangeColors, className } = this.props; | ||
|
||
return ( | ||
<div className={cx(styles.definedRangesWrapper, className)}> | ||
{this.props.headerContent} | ||
<div className={styles.staticRanges}> | ||
{this.props.staticRanges.map((staticRange, i) => { | ||
const { selectedRange, focusedRangeIndex } = this.getSelectedRange(ranges, staticRange); | ||
let labelContent; | ||
|
||
if (staticRange.hasCustomRendering) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's make There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Having |
||
labelContent = renderStaticRangeLabel(staticRange); | ||
} else { | ||
labelContent = staticRange.label; | ||
} | ||
|
||
return ( | ||
<button | ||
type="button" | ||
|
@@ -59,7 +71,7 @@ class DefinedRanges extends Component { | |
this.props.onPreviewChange && this.props.onPreviewChange(); | ||
}}> | ||
<span tabIndex={-1} className={styles.staticRangeLabel}> | ||
{staticRange.label} | ||
{labelContent} | ||
</span> | ||
</button> | ||
); | ||
|
@@ -106,6 +118,7 @@ DefinedRanges.propTypes = { | |
headerContent: PropTypes.any, | ||
rangeColors: PropTypes.arrayOf(PropTypes.string), | ||
className: PropTypes.string, | ||
renderStaticRangeLabel: PropTypes.func, | ||
}; | ||
|
||
DefinedRanges.defaultProps = { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
import React from 'react'; | ||
import { mount, shallow } from 'enzyme'; | ||
|
||
import DefinedRange from './DefinedRange'; | ||
import { isSameDay } from 'date-fns'; | ||
|
||
describe('DefinedRange tests', () => { | ||
test('Should call "renderStaticRangeLabel" callback correct amount of times according to the "hasCustomRendering" option', () => { | ||
const renderStaticRangeLabel = jest.fn(); | ||
|
||
mount( | ||
<DefinedRange | ||
staticRanges={[ | ||
{ | ||
label: 'Dynamic Label', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
hasCustomRendering: true, | ||
}, | ||
{ | ||
label: 'Static Label', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
}, | ||
{ | ||
label: 'Hede', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
hasCustomRendering: true, | ||
}, | ||
]} | ||
renderStaticRangeLabel={renderStaticRangeLabel} | ||
/> | ||
); | ||
|
||
expect(renderStaticRangeLabel).toHaveBeenCalledTimes(2); | ||
}); | ||
|
||
test('Should render dynamic static label contents correctly', () => { | ||
const renderItalicLabelContent = () => ( | ||
<i className={'italic-label-content'}>{'Italic Content'}</i> | ||
); | ||
const renderBoldLabelContent = () => <b className={'bold-label-content'}>{'Bold Content'}</b>; | ||
const renderSomethingElse = () => <img className={'random-image'} />; | ||
|
||
const renderStaticRangeLabel = function(staticRange) { | ||
let result; | ||
|
||
if (staticRange.id === 'italic') { | ||
result = renderItalicLabelContent(); | ||
} else if (staticRange.id === 'bold') { | ||
result = renderBoldLabelContent(); | ||
} else { | ||
result = renderSomethingElse(); | ||
} | ||
|
||
return result; | ||
}; | ||
|
||
const wrapper = shallow( | ||
<DefinedRange | ||
staticRanges={[ | ||
{ | ||
id: 'italic', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
hasCustomRendering: true, | ||
}, | ||
{ | ||
label: 'Static Label', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
}, | ||
{ | ||
id: 'whatever', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
hasCustomRendering: true, | ||
}, | ||
{ | ||
id: 'bold', | ||
range: {}, | ||
isSelected(range) { | ||
const definedRange = this.range(); | ||
return ( | ||
isSameDay(range.startDate, definedRange.startDate) && | ||
isSameDay(range.endDate, definedRange.endDate) | ||
); | ||
}, | ||
hasCustomRendering: true, | ||
}, | ||
]} | ||
renderStaticRangeLabel={renderStaticRangeLabel} | ||
/> | ||
); | ||
|
||
expect(wrapper).toMatchSnapshot(); | ||
}); | ||
}); |
Uh oh!
There was an error while loading. Please reload this page.