Fix infinite loop on OSX Catalina in activate.sh #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this in 10.15.1 Beta (19B86a) and this works as mentioned. |
eXamadeus
reviewed
Oct 28, 2019
| @@ -32,6 +32,7 @@ ${_file}" | |||
| fi | |||
| fi | |||
| [ "$(\pwd -P)" = "${_mountpoint}" ] && \break | |||
| [ "$(\pwd -P)" = "/" ] && \break | |||
There was a problem hiding this comment.
Suggestion: replace the whitespace with tabs to align with other formatting.
Suggested change
| [ "$(\pwd -P)" = "/" ] && \break | |
| [ "$(\pwd -P)" = "/" ] && \break |
There was a problem hiding this comment.
@emorikawa can you please update the PR with the suggested change?
|
but since it works, I realized this takes too much time just to change directory.. even |
|
Sorry for the staleness. Thank you @davidalee for addressing. Closing this in favor of #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
This implements @sennav and @meermanr's suggestion as a pull request.
Due to Catalina's new firmlinks, this fixes an infinite loop on OSX Catalina 10.15.
Manually running
source activate.shwill enter the infinite loop condition. Manually runningsource activate.shwith the line change returns nearly immediately and enables autoenv.