Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update option page theme #920

Conversation

frank-zsy
Copy link
Contributor

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

I am really fond of the VSCode default dark theme configs. So I implement a new theme for the option page which follows VSCode dark theme styles.

It looks like this now:

image

Don't know if you like this or not, just fire a PR first.

And since GitHub and Gitee token procedure will be updated, I did not correct the input component position right now.

Checklist

Others

Signed-off-by: frank-zsy <syzhao1988@126.com>
@wangyantong2000
Copy link
Collaborator

It looks beautiful.

@Xsy41
Copy link
Collaborator

Xsy41 commented Nov 13, 2024

Feel that the content and the background have a little degree of differentiation, will be more beautiful.

image

@frank-zsy
Copy link
Contributor Author

Feel that the content and the background have a little degree of differentiation, will be more beautiful.

I am not quite sure because VSCode setting does not have a background for main container area, this makes it consistent for different screen resolution.

@wangyantong2000
Copy link
Collaborator

There is indeed no distinction made in VSCode. Since it is in VSCode style, let's focus on the original VSCode style first. Continuously make adjustments in subsequent usage feedback. I will first resolve the conflict of this PR and then merge it.

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Nov 18, 2024

image Merge conflicts. I'm not sure if a circular button or a right angled button is the effect you want.

@wangyantong2000
Copy link
Collaborator

@Xsy41 After the refactoring work on the options page is merged, you can update and modify the comments on the token related part of the FastPR process in 911 again~

@wangyantong2000
Copy link
Collaborator

And after this PR is merged, a new version can be released. @Xsy41

@frank-zsy
Copy link
Contributor Author

@wangyantong2000 I think right-angled button is good.
image

@frank-zsy
Copy link
Contributor Author

@Xsy41 And https://hypercrx.cn is also ready now for the repo https://github.com/hypertrons/hypertrons-crx-website , you can also start to add the content of user docs on the website.

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Nov 18, 2024

@wangyantong2000 I think right-angled button is good. image

This doesn't look like a perfect right angle, it's like a circular button with a very small radius.
image
Like this?

image

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Nov 18, 2024

截屏2024-11-18 22 13 45

@frank-zsy
Copy link
Contributor Author

I am not quite sure, you can decide which style to use since the css is generated by GPT-4~

@Xsy41
Copy link
Collaborator

Xsy41 commented Nov 18, 2024

After the refactoring work on the options page is merged, you can update and modify the comments on the token related part of the FastPR process in 911 again~ And after this PR is merged, a new version can be released. And https://hypercrx.cn/ is also ready now for the repo https://github.com/hypertrons/hypertrons-crx-website , you can also start to add the content of user docs on the website.

OK, I’ll update the token-related comments for #911 after the refactoring work is merged and start adding user documentation to https://hypercrx.cn/ for the website repo.

@wangyantong2000 wangyantong2000 merged commit 82f2a7e into hypertrons:master Nov 18, 2024
3 checks passed
@frank-zsy frank-zsy deleted the refactor/refactor-option-page-theme branch November 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants